Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching GDPR Vendor Lists #511

Merged
merged 7 commits into from
May 17, 2018
Merged

Fetching GDPR Vendor Lists #511

merged 7 commits into from
May 17, 2018

Conversation

dbemiller
Copy link
Contributor

This partially supports #504. See part 2 of "Questions and complex details".

It also connects to some of the app config behavior described in #503:

If these are undefined, we will assume that the publisher doesn't care about GDPR and continue to sync users all the time.

@dbemiller dbemiller requested review from cirla and hhhjort May 16, 2018 19:25
hhhjort
hhhjort approved these changes May 16, 2018
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... assuming the gdpr library works as assumed here. I should read that, and then give this a second pass. But since this code doesn't actually do anything yet, should be safe to commit.

@cirla cirla merged commit 66b7589 into master May 17, 2018
@cirla cirla deleted the gdpr-fetch-vendorlists branch May 17, 2018 14:20
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
@dbemiller @cirla
Fetching GDPR Vendor Lists (prebid#511)
5fc8749 
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs

* Updated gopkg.lock.

* Moved the URL creation into a function.

* Made the URL-maker function a method arg, so it could be mocked out during testing.

* Started some test helper code.

* Added lots of tests.
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
@dbemiller @cirla
Fetching GDPR Vendor Lists (prebid#511)
b6f86e1 
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs

* Updated gopkg.lock.

* Moved the URL creation into a function.

* Made the URL-maker function a method arg, so it could be mocked out during testing.

* Started some test helper code.

* Added lots of tests.
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
@dbemiller @cirla
Fetching GDPR Vendor Lists (prebid#511)
9304f4f 
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs

* Updated gopkg.lock.

* Moved the URL creation into a function.

* Made the URL-maker function a method arg, so it could be mocked out during testing.

* Started some test helper code.

* Added lots of tests.
pm-nilesh-chate added a commit to pm-nilesh-chate/prebid-server that referenced this pull request Jun 21, 2023
@pm-nilesh-chate
UOE-9292: decouple pbs and sshb startup (prebid#511)
ffeb7c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirla cirla cirla approved these changes

@hhhjort hhhjort hhhjort approved these changes

Assignees

@cirla cirla

@hhhjort hhhjort

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbemiller @cirla @hhhjort