Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR-friendly /setuid #513

Merged
merged 9 commits into from
May 22, 2018
Merged

GDPR-friendly /setuid #513

merged 9 commits into from
May 22, 2018

Conversation

dbemiller
Copy link
Contributor

@dbemiller dbemiller commented May 18, 2018

This fixes #504, updating the /setuid endpoint. See the issue (or the docs in the PR) for the behavior.

@dbemiller dbemiller added the External API impact Tag for issues and PRs which affect the external API label May 18, 2018
cirla
cirla previously approved these changes May 18, 2018
hhhjort
hhhjort previously approved these changes May 18, 2018
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbemiller dbemiller dismissed stale reviews from hhhjort and cirla via 165bbe2 May 18, 2018 15:03
@dbemiller dbemiller merged commit 565e118 into master May 22, 2018
@dbemiller dbemiller deleted the gdpr-setuid branch May 22, 2018 15:19
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
* Implemented a GDPR-aware /setuid endpoitn.

* Made the gdpr module return a special error type if the cause of the error was a bad consent string.

* Added docs.

* Better docs.

* Added metrics for syncs prevented by GDPR.

* Added a test for the new metrics code.

* Moved the TODO in pbs_light.go so that it overlaps with the other PR, and will cause conflcits.

* Fixed vet error.
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
* Implemented a GDPR-aware /setuid endpoitn.

* Made the gdpr module return a special error type if the cause of the error was a bad consent string.

* Added docs.

* Better docs.

* Added metrics for syncs prevented by GDPR.

* Added a test for the new metrics code.

* Moved the TODO in pbs_light.go so that it overlaps with the other PR, and will cause conflcits.

* Fixed vet error.
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
* Implemented a GDPR-aware /setuid endpoitn.

* Made the gdpr module return a special error type if the cause of the error was a bad consent string.

* Added docs.

* Better docs.

* Added metrics for syncs prevented by GDPR.

* Added a test for the new metrics code.

* Moved the TODO in pbs_light.go so that it overlaps with the other PR, and will cause conflcits.

* Fixed vet error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External API impact Tag for issues and PRs which affect the external API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDPR Endpoint Logic
3 participants