Creat a Fail-To_Bid error #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirla
previously approved these changes
Aug 1, 2018
dbemiller
reviewed
Aug 1, 2018
pbsmetrics/metrics.go
Outdated
| @@ -146,6 +146,7 @@ const ( | |||
| AdapterErrorBadInput AdapterError = "badinput" | |||
| AdapterErrorBadServerResponse AdapterError = "badserverresponse" | |||
| AdapterErrorTimeout AdapterError = "timeout" | |||
| AdapterErrorFailedToBid AdapterError = "failedtobid" | |||
There was a problem hiding this comment.
Name seems a bit confusing to me... if you were unfamiliar with the project and saw the metrics, how do you think this would compare with nobid?
Maybe failedtorequest would be more accurate?
There was a problem hiding this comment.
Yes, that is what I use elsewhere, Not sure how I got off track here. Thanks
dbemiller
approved these changes
Aug 1, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Initial implementation * Makes naming more consistent
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Initial implementation * Makes naming more consistent
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Initial implementation * Makes naming more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapters should either generate one or more http requests to their bidder to get bids, or return errors indicating why they could not bid on the supplied bid request (or both). However this is not enforced. This PR adds a failedToBid error to catch this case, and signal that an adapter is misbehaving in this manner. This should hopefully never happen, but now we will be able to catch and debug if it ever does.