Use jsonparser fork #637
Merged
Use jsonparser fork #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
approved these changes
Aug 2, 2018
cirla
approved these changes
Aug 2, 2018
| [[constraint]] | ||
| branch = "master" | ||
| name = "github.com/buger/jsonparser" | ||
| source = "https://github.com/dbemiller/jsonparser.git" |
There was a problem hiding this comment.
Do we want this fork to live in the prebid github org? Probably not worth it if we're intending to switch back to upstream after a single PR is merged.
There was a problem hiding this comment.
yeah... I considered that too. I chose not to put it in the prebid org just because I didn't want to pollute the namespace. Hopefully this is a short-lived fork.
We can always move it if it turns out to be a long-lived fork and we care that much. At this point, we don't even know for certain that this will get rid of the panics, or whether it will cause other bugs... so that seemed a little premature.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our project to a
jsonparserfork which includes buger/jsonparser#137, because that project's maintainer hasn't responded in a while.I also tried replacing
jsonparserwith gjson... but our benchmark showed an extra millisecond of overhead, so... shrugs.I believe this should fix some panics we've been seeing in the app logs. Once it merges we can switch back to the main project.
It upgrades lots of other packages too. Honestly this happened by accident when I deleted
Gopkg.lockand randep ensure. If you think that's too risky, I can go back and update just this package... but IMO we're due for some dependency upgrades anyway.