Cache vast xml #643
Merged
Cache vast xml #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
added
the
External API impact
hhhjort
reviewed
Aug 3, 2018
exchange/exchange.go
Outdated
| if requestExt.Prebid.Cache != nil { | ||
| shouldCacheBids = requestExt.Prebid.Cache.Bids != nil | ||
| shouldCacheVAST = requestExt.Prebid.Cache.VastXML != nil | ||
| } | ||
| shouldCacheBids = requestExt.Prebid.Cache != nil && requestExt.Prebid.Cache.Bids != nil |
There was a problem hiding this comment.
Isn't this line redundant with the above?
There was a problem hiding this comment.
yes, thank you. will remove
cirla
approved these changes
Aug 3, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Made some changes to support VAST cacheing. * Implemented vastxml cacheing. * Fixed JSON in markdown. * Added endpoint contract tests. * Removed redundant line.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Made some changes to support VAST cacheing. * Implemented vastxml cacheing. * Fixed JSON in markdown. * Added endpoint contract tests. * Removed redundant line.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Made some changes to support VAST cacheing. * Implemented vastxml cacheing. * Fixed JSON in markdown. * Added endpoint contract tests. * Removed redundant line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324.
This does not implement
ttlseconds, which was described in the ticket as optional. To support that, we'll need to add it to the whole stack (down through Prebid Cache)... so it would be another few PRs.