Required some size to exist on banner requests #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Aug 6, 2018
endpoints/openrtb2/auction.go
Outdated
| @@ -355,6 +355,11 @@ func validateBanner(banner *openrtb.Banner, impIndex int) error { | |||
| return fmt.Errorf("request.imp[%d].banner uses unsupported property: \"hmax\". Use the \"format\" array instead.", impIndex) | |||
| } | |||
|
|
|||
| hasRootSize := banner.H != nil && banner.W != nil | |||
There was a problem hiding this comment.
shouldn't this be banner.H != nil || banner.W != nil? We need both for a size.
There was a problem hiding this comment.
this is defining hasRootSize, in the positive. Like you said, we need both to have one.
There was a problem hiding this comment.
all good. It did point me to the fact that you could still set these to 0, which isn't helpful either.
I added some logic for that & a few more tests.
dbemiller
added
the
breaking change - callers
dbemiller
force-pushed
the
require-banner-sizes
branch
from
73af6b1 to
066c7a2
Compare
cirla
approved these changes
Aug 6, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Required some size to exist on banner requests. * Added more tests. Fixed the code a bit.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Required some size to exist on banner requests. * Added more tests. Fixed the code a bit.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Required some size to exist on banner requests. * Added more tests. Fixed the code a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #644, I found this test which wasn't testing what it thought it was.
It intended to make sure we reject sizeless banners... but it was failing for other reasons.
Unfortunately, this is now a breaking change :(. Still probably better late than never. We can measure its true impact whenever we release it.