Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CORS error #649

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Fixing CORS error #649

merged 1 commit into from
Aug 8, 2018

Conversation

dbemiller
Copy link
Contributor

Fixes #648.

Lots of documentation, because it's a tricky subject and took a lot of digging before I even convinced myself that it was ok.

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... had to go back and read everything to understand why the CORS PR broke our setup and this fixes. We are basically restoring the original insecure behavior, because as you note, we are not using any information for authentication, just to facilitate the reading of public IDs.

@hhhjort hhhjort merged commit 1a2c06d into master Aug 8, 2018
@hhhjort hhhjort deleted the fix-cors-bug branch August 8, 2018 12:54
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants