Cors regression test #650
Merged
Cors regression test #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
requested review from
cirla and
hhhjort
and removed request for
cirla
cirla
previously approved these changes
Aug 8, 2018
hhhjort
reviewed
Aug 8, 2018
pbs_light_test.go
Outdated
| } | ||
| cors.ServeHTTP(rr, req) | ||
| assert.NotEqual(t, "*", rr.Header().Get("Access-Control-Allow-Origin")) | ||
| } |
There was a problem hiding this comment.
Do we want to test if the Access-Control-Allow-Origin matches the Origin we set in the request?
There was a problem hiding this comment.
Yes... very good idea. Done
hhhjort
previously approved these changes
Aug 8, 2018
cirla
approved these changes
Aug 13, 2018
hhhjort
approved these changes
Aug 13, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Added a regression test for the cors bug. * Fixed the test. * Better cors regression test.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Added a regression test for the cors bug. * Fixed the test. * Better cors regression test.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Added a regression test for the cors bug. * Fixed the test. * Better cors regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing #648 more safely.