Formalizing support for site.ext.amp
#711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
changed the title
site.ext.ampsite.ext.amp
hhhjort
reviewed
Oct 10, 2018
endpoints/openrtb2/auction.go
Outdated
| } | ||
| } | ||
|
|
||
| func setAmpExt(site *openrtb.Site, value string) { |
There was a problem hiding this comment.
Any particular reason you put this in auction.go rather than amp_auction.go?
There was a problem hiding this comment.
No reason... but that makes sense. I'll move it.
It's used in both files... started out named something else, but with "amp" in the name I can definitely see how it fits better in the amp_auction file.
hhhjort
previously approved these changes
Oct 10, 2018
hhhjort
approved these changes
Oct 11, 2018
mkendall07
approved these changes
Oct 22, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Started adding some code to validate the amp ext, and some unit tests which dont pass yet. * Fixed some bugs. Added more tests. * Updated the docs. * Fixed some tests... but not all. * Fixed last remaining bug. * Moved setAmpExt to the amp_auction file.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Started adding some code to validate the amp ext, and some unit tests which dont pass yet. * Fixed some bugs. Added more tests. * Updated the docs. * Fixed some tests... but not all. * Fixed last remaining bug. * Moved setAmpExt to the amp_auction file.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Started adding some code to validate the amp ext, and some unit tests which dont pass yet. * Fixed some bugs. Added more tests. * Updated the docs. * Fixed some tests... but not all. * Fixed last remaining bug. * Moved setAmpExt to the amp_auction file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #708
Technically the
extwas already going to the bidders... so this just adds input validation & documents it.Along the way, I found that our AMP tests were testing lots of payloads with
request.appdefined. Since AMP impliessite, these tests don't make sense. I added an explicit check forrequest.appin the code.This seems like a breaking change... but I don't think it is, because a real AMP page would send the
curlquery param, and there was already code which definedsitein that case. If the Stored Request already definedapp, then it would cause both to be defined, which would make the request invalid anyway.