Update ix adapter to make multiple bid requests for multiple slots and sizes #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ix-certification
commented
Oct 23, 2018
•
ix-certification
commented
- added support for sending multiple bid requests to IX for multiple slots and sizes
- resolves issue mentioned in Rename indexExchange to ix (#657) #712 (comment)
- resolves comment Rename indexExchange to ix (#657) #712 (comment)
- resolves comment Rename indexExchange to ix (#657) #712 (comment)
hhhjort
reviewed
Oct 29, 2018
hhhjort
reviewed
Oct 29, 2018
hhhjort
reviewed
Oct 31, 2018
dbemiller
suggested changes
Oct 31, 2018
There was a problem hiding this comment.
A few things need fixing before we can merge this. Those are in the comments.
As an aside, you may find this code easier to write & maintain if you use the Bidder interface, rather than the legacy Adapter one. The Bidder contract is is much like Prebid.js 1.x adapters, while the Adapter one is a lot like Prebid.js 0.x adapters. There's also documentation for it, and the test code is easier to write too.
See eplanning or rhythmone for examples if you want to go that route. Not required for merge, though, as long as you fix the race condition and unreliable test.
hhhjort
approved these changes
Nov 5, 2018
dbemiller
approved these changes
Nov 5, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
…d sizes (prebid#725) * Update ix adapter to make multiple bid requests for multiple slots and sizes * Change string typecasting * fix race condition * refactor to minimize a race condition on slower machines
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
…d sizes (prebid#725) * Update ix adapter to make multiple bid requests for multiple slots and sizes * Change string typecasting * fix race condition * refactor to minimize a race condition on slower machines
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
…d sizes (prebid#725) * Update ix adapter to make multiple bid requests for multiple slots and sizes * Change string typecasting * fix race condition * refactor to minimize a race condition on slower machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.