Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted the loadtype targeting key #750

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

dbemiller
Copy link
Contributor

Fixes #749.

Prebid Mobile says they've given up trying to integrate Facebook in the SDK... so this key really doesn't serve any purpose anymore.

@dbemiller dbemiller requested a review from hhhjort November 15, 2018 19:13
@dbemiller dbemiller added the breaking change - callers Has breaking API changes for those calling Prebid Server endpoints label Nov 15, 2018
@dbemiller
Copy link
Contributor Author

@bretg this seems like a fairly big deal... you should make sure you're on the same page as the Prebid Mobile people.

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable for what it does ... but lets let Bret chime in.

@bretg
Copy link
Contributor

bretg commented Nov 16, 2018

I've reached out to the mobile team.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got a response from the mobile team - confirmed to go ahead with this PR

@dbemiller dbemiller merged commit 73ad292 into master Nov 26, 2018
@dbemiller dbemiller deleted the delete-loadtype-targeting branch November 26, 2018 14:00
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change - callers Has breaking API changes for those calling Prebid Server endpoints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants