Moved bid validation into some adapter middleware. #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
approved these changes
Dec 14, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Moved bidd validation into some adapter middleware. * Ran gofmt -s to fix the build.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Moved bidd validation into some adapter middleware. * Ran gofmt -s to fix the build.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Moved bidd validation into some adapter middleware. * Ran gofmt -s to fix the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the same issue as #770... but makes some more structural changes that minimize the chances of it happening again later. It's mostly a cut/paste job with some very minor tweaks.
This moves bid validation into a piece of adapter middleware, so that the validation logic isn't interleaved with unrelated metrics logic the way it is today.
In future PRs (though I doubt they'll come from me), you could probably isolate
metricslogging,panicrecovery,analyticsmodule stuff, into other, similar types of middleware. The more code that moves into small pieces that do one well-defined thing each, the easier a time you'll have finding & fixing bugs like this.