Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate HTTP headers when provided in JSON test requests #795

Merged
merged 3 commits into from
Feb 6, 2019
Merged

Validate HTTP headers when provided in JSON test requests #795

merged 3 commits into from
Feb 6, 2019

Conversation

nealeu
Copy link
Contributor

@nealeu nealeu commented Jan 21, 2019

See #793

@nealeu nealeu mentioned this pull request Jan 29, 2019
Merged
hhhjort
hhhjort approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review. It looks good to me.

@hhhjort hhhjort merged commit ce4b2b2 into prebid:master Feb 6, 2019
@nealeu nealeu deleted the test-http-headers branch February 6, 2019 16:50
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
@nealeu @hhhjort
Validate HTTP headers when provided in JSON test requests (prebid#795)
9cde1fb 
* Validate HTTP headers when found in test data expectedRequest

* Corrections to somoaudience test data now HTTP headers are validated

* Corrections to sovrn test data now HTTP headers are validated
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
@nealeu @hhhjort
Validate HTTP headers when provided in JSON test requests (prebid#795)
e5531de 
* Validate HTTP headers when found in test data expectedRequest

* Corrections to somoaudience test data now HTTP headers are validated

* Corrections to sovrn test data now HTTP headers are validated
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
@nealeu @hhhjort
Validate HTTP headers when provided in JSON test requests (prebid#795)
a99a850 
* Validate HTTP headers when found in test data expectedRequest

* Corrections to somoaudience test data now HTTP headers are validated

* Corrections to sovrn test data now HTTP headers are validated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhhjort hhhjort hhhjort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nealeu @hhhjort