[Go 1.9] deprecate 1.9 & 1.10 versions and introduce 1.12 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
previously approved these changes
Jun 6, 2019
guscarreon
requested changes
Jun 10, 2019
There was a problem hiding this comment.
Since Go only supports the last two major releases, versions 1.11 and 1.12 are the only ones currently being supported. Do you think we should try to deprecate 1.10.x too?
Sure ! :) |
benjaminch
force-pushed
the
deprecate-go-1.9
branch
from
9143afb to
efdf140
Compare
benjaminch
changed the title
benjaminch
force-pushed
the
deprecate-go-1.9
branch
from
efdf140 to
9fa8fda
Compare
This CL deprecates Go 1.9 & 1.10 versions removing it from the CI along updating the installation instructions and add Go 1.12 support. Issue: prebid#920
benjaminch
force-pushed
the
deprecate-go-1.9
branch
from
9fa8fda to
56da42f
Compare
|
Hey @guscarreon seems that 1.12 requires a bit more work especially around Cheers! |
Worked perfeclty. LGTM |
guscarreon
approved these changes
Jun 17, 2019
|
Thanks @guscarreon :) |
hhhjort
approved these changes
Jun 18, 2019
mansinahar
added a commit
that referenced
this pull request
Jun 18, 2019
This reverts commit b1829f0.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
This CL deprecates Go 1.9 & 1.10 versions removing it from the CI along updating the installation instructions and add Go 1.12 support. Issue: prebid#920
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
This CL deprecates Go 1.9 & 1.10 versions removing it from the CI along updating the installation instructions and add Go 1.12 support. Issue: prebid#920
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
This CL deprecates Go 1.9 & 1.10 versions removing it from the CI along updating the installation instructions and add Go 1.12 support. Issue: prebid#920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL deprecates Go 1.9 version removing it from the CI along updating
the installation instructions.
This PR probably needs to be flagged as important change so people using Go 1.9 will be aware of this change from now on.
Issue: #920