Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playgroundxyz adapter documentation update #1203

Closed
wants to merge 1 commit into from

Conversation

monofonik
Copy link
Contributor

This change informs users of the playgroundxyz adapter to use the aliased name pxyz, avoiding complications with DFP character limits

This change informs users of the playgroundxyz adapter to use the aliased name pxyz, avoiding complications with DFP character limits
@bretg
Copy link
Contributor

bretg commented Mar 18, 2019

@monofonik - Unfortunately this isn't going to work the way you want it to.

The Download system assumes that the biddercode maps to the actual module filename. So setting bidderCode=pxyz, it will try to find a module called pxyzBidAdapter. We can use an aliasCode to do the right thing, but would like to confirm the desired outcome here

What do you want to appear in http://prebid.org/dev-docs/bidders.html#playgroundxyz ? I'm guessing you want to have Playground XYZ, but show the biddercode pxyz.

We don't currently allow a bidder code 'override' - the standard way to do this is to create a new file pxyz. While it's not unreasonable to support an override so you can have the best of both worlds, there is a drawback, and that's the installed base.

If we change to the shorter biddercode, anyone who has the longer biddercode will no longer have the DFP targeting variables. If that's ok, I'll go ahead and add a 'bidderCodeDisplay' override.

@bretg bretg self-assigned this Mar 18, 2019
@bretg
Copy link
Contributor

bretg commented Sep 5, 2019

@monofonik - is this still of interest?

@monofonik
Copy link
Contributor Author

Hi @bretg sorry I missed your reply back in March... so if I understand you correctly, implementing the "bidder code override" you've suggested would potentially disrupt existing publishers who've correctly implemented the truncated "playgroundxyz" targeting variables (when they eventually update their Prebid adapter version)?

If this is the case then I think we'll just stick with the status quo. Let me know if I've misunderstood.

Cheers

@bretg
Copy link
Contributor

bretg commented Sep 7, 2019

I've added a feature to the doc site to make it possible to prefer a shorter bidder code like this. However, because this PR is so old, I'm going to close it, will open another and provide a screenshot of what the page will look like so you can approve.

@bretg bretg closed this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants