Module - Docs for Size Mapping V2 #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Closed
|
Hey @bretg, request you to have a look at this please, when you get time. The PR related to this has already gone out in the previous release. |
bretg
approved these changes
Mar 16, 2020
|
Good first cut @Fawke - thanks. Made a round of changes and passing over to @jeanstemp for more wordsmithing. Note that I've given this thing a 'marketing' name of "Advanced Size Mapping" -- it was not the intention to obsolete the core sizeConfig. So I put some effort into explaining the scenarios in which you'd use one approach over the other. Might want to check that out and see if you agree. |
|
I agree with the changes you've made; the doc for the feature is now more comprehensive. The name is also fine. Thanks @bretg |
jeanstemp
approved these changes
Mar 18, 2020
|
As always, better and more consistent after your edits. Thanks @jeanstemp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the new size mapping spec. Link to the spec, prebid/Prebid.js#4129.
Link to the PR in Prebid.js repo. prebid/Prebid.js#4690