Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing waardex file without .md extension #2142

Closed
wants to merge 1 commit into from
Closed

Conversation

bretg
Copy link
Contributor

@bretg bretg commented Jul 17, 2020

@romanantropov - found that there were two waardex files -- one with a .md extension, one without.

Noticed that the adkernelBidAdapter.js file still refers to waardex_ak as an alias, and this extension-less file referred to waardex_ak.

Please confirm that we can remove this file -- it won't show up on the website without the extension, and there's already a waardex.md file.

@romanantropov
Copy link
Contributor

@bretg we need both bidders to be presented still because of the transition period

@bretg
Copy link
Contributor Author

bretg commented Aug 13, 2020

@romanantropov - waardex_ak doesn't show up anywhere because the waardex file doesn't have an extension

❯ grep waardex_ak *
waardex:biddercode: waardex_ak

Where do you want the _ak version to appear?

@bretg
Copy link
Contributor Author

bretg commented Sep 21, 2020

I took matters into my own hands here and renamed the extensionless file to waardex.ak in #2352

@bretg bretg closed this Sep 21, 2020
@bretg bretg deleted the waardex-cleanup branch September 21, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants