Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect that native asset's ID field is optional #2449

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

mansinahar
Copy link
Contributor

Addresses prebid/prebid-server#1517

Currently the documentation says that native asset object's ID is not to be defined in the request. However, both Prebid Server Go and Prebid Server Java treat this as an optional field such that if the asset's ID isn't provided in the request, it assigns it based on the asset's index value in the array of assets. This behavior makes sense because if the request is requesting two types of data assets such as sponsored (type: 1) and desc (type: 2), and if the assets in the response don't have the types set (Based on the openrtb native spec the type field in the data asset response object is optional) then there's no way for the Publisher to know which data asset is of which type. Therefore, updating the documentation to reflect this behavior.

Ref to Prebid Server Go: https://github.com/prebid/prebid-server/blob/7b50f96df28dfcecfdfce97f62b13b79596a40ea/endpoints/openrtb2/auction.go#L575-L588

Ref to Prebid Server Java: https://github.com/rubicon-project/prebid-server-java/blob/05a5b119ede5ed404289794d50b201706cd8b45a/src/main/java/org/prebid/server/validation/RequestValidator.java#L577

@bretg bretg merged commit a45558f into prebid:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants