DeepIntent: PBS docs added #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Nov 19, 2020
|
@sourabhg - this is a pretty big problem:
the pbsBidAdapter does not create imp.banner.h/w. It creates imp.banner[].format.h/w I'm checking with the mobile team to see what the SDK does. But at this point, you can't expect imp.banner.h/w to exist. I think you need to update your adapter to look in It's ok if your endpoint doesn't support |
|
Confirmed that SDK doesn't set imp.banner.h/w. either. |
bretg
approved these changes
Nov 25, 2020
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
Co-authored-by: Sourabh Gandhe <sourabh@Sourabhs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebid server docs added