Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum: adds note that mediaType video is required for video products #2551

Merged
merged 12 commits into from
Dec 4, 2020

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Dec 3, 2020

related prebid.js PR: prebid/Prebid.js#6066



Please note that both video and in-video products require a mediaType of video.
All other products (in-screen, slot, native) should have a mediaType of banner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - Prebid doesn't recommend delivering native ads through 'mediaType.banner'. If this is necessary, then we will soon require that you set meta.mediaType="native" on the bidResponse object.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this, but please consider the comment about piggybacking native on the banner mediaType.

@bretg bretg merged commit 2718041 into prebid:master Dec 4, 2020
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
…prebid#2551)

* specifies us privacy is supported

* adds video support to gumgum md

* adds support for tcf 2

* adds new bid param to gumgum.md

* updates gumgum doc

* notes required mediaType for video products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants