Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inmarId from Inmar bidder adapter params, add user IDs #2588

Merged
merged 8 commits into from
Jan 7, 2021

Conversation

zandree-owneriq
Copy link
Contributor

Cleared up confusion about how user IDs work in prebid. No longer need this parameter.

Code change in this pull request: prebid/Prebid.js#6136

@zandree-owneriq
Copy link
Contributor Author

Are we able to get this merged?

@zandree-owneriq
Copy link
Contributor Author

Can we get an update on this?

@zandree-owneriq zandree-owneriq changed the title Remove inmarId from Inmar bidder adapter params Remove inmarId from Inmar bidder adapter params, add pubCommonId to user ID list Jan 5, 2021
@zandree-owneriq zandree-owneriq changed the title Remove inmarId from Inmar bidder adapter params, add pubCommonId to user ID list Remove inmarId from Inmar bidder adapter params, add user IDs Jan 6, 2021
@bretg
Copy link
Contributor

bretg commented Jan 7, 2021

part of 4.21

@bretg bretg added the LGTM label Jan 7, 2021
@bretg bretg merged commit 6653c64 into prebid:master Jan 7, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
…#2588)

* Add Inmar bidder adapter

* Update Inmar bidder adapter documentation

* Update Inmar bidder adapter documentation

* Remove inmarId from userIds

* Remove inmarId from Inmar bidder adapter

* Add pubCommonId to Inmar user IDs

* Add sharedId to Inmar user IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants