Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Zemanta to Outbrain #2596

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

rokostik
Copy link
Contributor

Hey!
This PR renames the Zemanta adapter to Outbrain. We only want Outbrain to be seen to publishers so the biddercode and naming in the source code stays the same.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but you're going to need to make some code changes before this is going to work. The docs name and the actual code name need to align. You have two choices:

  1. rename https://github.com/prebid/Prebid.js/blob/master/modules/zemantaBidAdapter.js to outbrainBidAdapter.js
  2. add 'outbrain' as an alias in zemantaBidAdapter.js (see appnexusBidAdapter for an example) then add an aliasCode header to this doc file. See districtm.md here for an example.

@rokostik
Copy link
Contributor Author

Hey @bretg, thanks for helping and providing the instructions on how to properly implement this.
We went with option 2 and the code PR is located here: prebid/Prebid.js#6203.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that by renaming this file, any customer that currently uses 'zemanta' will no longer see the biddercode on the docs site. If that's ok with you, this should work.

If you have customers using the zemanta bidder code, then you should consider having both outbrain.md and zemanta.md

@rokostik
Copy link
Contributor Author

Hey @bretg, since pbjs was released yesterday can you merge this into master? Thanks!

@bretg
Copy link
Contributor

bretg commented Jan 28, 2021

part of 4.24

@bretg bretg merged commit df95dbd into prebid:master Jan 28, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Feb 23, 2021
* rename zemanta to outbrain

* configure outbrain as an alias for zemanta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants