-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Zemanta to Outbrain #2596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but you're going to need to make some code changes before this is going to work. The docs name and the actual code name need to align. You have two choices:
- rename https://github.com/prebid/Prebid.js/blob/master/modules/zemantaBidAdapter.js to outbrainBidAdapter.js
- add 'outbrain' as an alias in zemantaBidAdapter.js (see appnexusBidAdapter for an example) then add an
aliasCode
header to this doc file. See districtm.md here for an example.
Hey @bretg, thanks for helping and providing the instructions on how to properly implement this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that by renaming this file, any customer that currently uses 'zemanta' will no longer see the biddercode on the docs site. If that's ok with you, this should work.
If you have customers using the zemanta bidder code, then you should consider having both outbrain.md and zemanta.md
Hey @bretg, since pbjs was released yesterday can you merge this into master? Thanks! |
part of 4.24 |
* rename zemanta to outbrain * configure outbrain as an alias for zemanta
Hey!
This PR renames the Zemanta adapter to Outbrain. We only want Outbrain to be seen to publishers so the biddercode and naming in the source code stays the same.