Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video docs waardex #2629

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

yegorWaardex
Copy link
Contributor

No description provided.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted over in the code PR, Prebid's goal is that bidders should not make publishers specify video parameters in each bidder-specific params area. video parameters should go be read by the adapter from mediatypes.video first.

It's ok if an adapter looks in both places, but the documentation needs to let publishers know that they can place these params up at the mediatypes level and not have to replicate them here.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well, we'll merge this, but you're going to have to clean this up someday - probably with 5.0

@bretg bretg merged commit 3d3af7e into prebid:master Feb 12, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Feb 23, 2021
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants