Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD auctionDelay and waitForIt flag #2642

Merged
merged 4 commits into from
Jan 25, 2021
Merged

RTD auctionDelay and waitForIt flag #2642

merged 4 commits into from
Jan 25, 2021

Conversation

bretg
Copy link
Contributor

@bretg bretg commented Jan 20, 2021

A recent PR found a gap in the Real-Time Data documentation that this aims to close.

@bretg bretg requested a review from jeanstemp January 20, 2021 21:58
@jeanstemp
Copy link
Contributor

@bretg I added a few things to hopefully clarify a little. But I have a few of questions:

  • What happens if you set waitForIt to true but don't put in an auctionDelay value? How long will it wait?
  • What if you do the opposite, set an auctionDelay value without making any waitForIt true? Will the auctionDelay value be ignored?
  • Is the default for waitForIt false?

@jeanstemp jeanstemp removed their request for review January 22, 2021 01:04
@bretg
Copy link
Contributor Author

bretg commented Jan 22, 2021

Thanks for the questions @jeanstemp -- added a "notes" section and the default values.

@bretg bretg merged commit ddc4384 into master Jan 25, 2021
@bretg bretg deleted the rtd-clarifications branch January 25, 2021 14:44
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Feb 23, 2021
* RTD auctionDelay and waitForIt flag

* wordsmithing

* minor edits

* describing waitForIt edge cases

Co-authored-by: Jean Stemp <jstemp@appnexus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants