Bid Viewability module documentation #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bretg
approved these changes
Jan 28, 2021
|
Thank you @bretg ! |
|
Hello @bretg , |
|
@bretg, gentle reminder to merge the PR |
|
Hello @bretg, gentle reminder to merge the PR |
|
@pm-harshad-mane - we don't merge docs PRs until after the code is released -- not after it's merged. Because it's live on the site immediately once merged. For the record, there's a website rotation and the person on-duty should be merging PRs that are ready. It's not my week, but I'll merge this for you. |
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Feb 23, 2021
* API fix * bidViewability module documentation * wordsmithing * adding link * update for onBidViewable * now we add ? in URL if not present * change in params, added enabled param Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer PrebidJS PR: prebid/Prebid.js#6206
Also added an API fix in documentation of Instream tracking module