Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamoshi - Add tcf2 support #2698

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Gamoshi - Add tcf2 support #2698

merged 2 commits into from
Mar 11, 2021

Conversation

sa1omon
Copy link
Contributor

@sa1omon sa1omon commented Feb 15, 2021

No description provided.

bretg
bretg requested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa1omon - why are you removing mobfoxx and cleanmedia? The gamoshi adapter still supports them:

gamoshiBidAdapter.js:  aliases: ['gambid', 'cleanmedia', '9MediaOnline', 'MobfoxX'],

Don't see a PR to remove support for them.

@bretg bretg added the question label Feb 17, 2021
@sa1omon sa1omon mentioned this pull request Feb 24, 2021
Merged
2 tasks
@bretg
Copy link
Contributor

bretg commented Mar 2, 2021

@sa1omon ^^

@bretg
Copy link
Contributor

bretg commented Mar 2, 2021

I see, the adapters were removed in 6355 and just merged.

@bretg bretg merged commit 8a56dbd into prebid:master Mar 11, 2021
@bretg bretg mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg requested changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sa1omon @bretg @jeanstemp