Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbrain prebid server support and new params #2796

Closed

Conversation

rokostik
Copy link
Contributor

Hey!

This PR adds documentation about our prebid server adapter and two new bidding params: bcat and badv

@bretg
Copy link
Contributor

bretg commented Apr 1, 2021

@rokostik - please fix the merge conflicts

@rokostik
Copy link
Contributor Author

rokostik commented Apr 9, 2021

Hey @bretg since both the referenced PRs have been merged and the conflicts resolved could this PR be merged too?

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that you're using ## here instead of ###. Please start your heading at level 3.

@bretg
Copy link
Contributor

bretg commented Apr 12, 2021

since both the referenced PRs have been merged

We don't merge docs PRs until the code has been released. This doc request will be merged once PBJS 4.35 is released, normally on a Weds. But please either fix the heading level or give me permission to do so in your fork.

@rokostik
Copy link
Contributor Author

I'm closing this PR, since #2847 was already merged and contains all commits from this PR.

@rokostik rokostik closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants