Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for AdUp Technology bid adapter #2978

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Update docs for AdUp Technology bid adapter #2978

merged 1 commit into from
Jun 4, 2021

Conversation

SteffenAnders
Copy link
Contributor

@SteffenAnders SteffenAnders commented May 20, 2021 •
edited
Loading

Type of change

  • Other

Description of change

  • Add Support for native mediaType
  • Fixup description
  • Updated parameters

@SteffenAnders SteffenAnders mentioned this pull request May 20, 2021
Merged
5 tasks
MartianTribe
MartianTribe reviewed May 26, 2021
View reviewed changes
Copy link
Collaborator

@MartianTribe MartianTribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, it's not a block though.

dev-docs/bidders/aduptech.md Outdated Show resolved Hide resolved
@SteffenAnders SteffenAnders force-pushed the optimize_aduptech_adapter branch 2 times, most recently from 2b2559f to 27c3de9 Compare May 31, 2021 06:20
@SteffenAnders
Copy link
Contributor Author

fyi: @MartianTribe prebid/Prebid.js#6800 was merged

bretg
bretg requested changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bid params table is missing the 'type' column. Please see other bidders. Am guessing string/string/string/boolean?

@SteffenAnders
Copy link
Contributor Author

@bretg fixed 👍

bretg
bretg approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bretg bretg merged commit c59a93e into prebid:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartianTribe MartianTribe MartianTribe left review comments

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
needs work not merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteffenAnders @bretg @MartianTribe