-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SharedId docs with Conversant content #3137
Conversation
updating the table and text of Sharedid (FKA pubcommon's) entry in the user id section.
adding docs from Conversant's site as requested in #2525
identity/sharedid.md
Outdated
| --- | --- | --- | --- | --- | --- | | ||
| 3rd Party Cookie Only | No first party cookie solution. | Some Blocked | Blocked | None | Low | | ||
| Prebid User Id | Including User Id Module in your Prebid installation. | 365 days | 7 days | Basic | Good | | ||
| PubCID Script | Adding the PubCID script to work with our ad code or a custom integration. | 365 days | 7 days | Basic | Good | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legacy method one might use without prebid, no longer recommended.
I would change Description to
'Adding the legacy PubCID script; not maintained by Prebid.org'
Technical Difficulty to 'High' and Revenue to 'Varies'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
| Implementation | Description | Cookie Lifetime | SAFARI COOKIE LIFETIME | TECHNICAL DIFFICULTY | REVENUE BENEFIT | | ||
| --- | --- | --- | --- | --- | --- | | ||
| 3rd Party Cookie Only | No first party cookie solution. | Some Blocked | Blocked | None | Low | | ||
| Prebid User Id | Including User Id Module in your Prebid installation. | 365 days | 7 days | Basic | Good | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User Id Submodule | 'Prebid.js installation' not Prebid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
| 3rd Party Cookie Only | No first party cookie solution. | Some Blocked | Blocked | None | Low | | ||
| Prebid User Id | Including User Id Module in your Prebid installation. | 365 days | 7 days | Basic | Good | | ||
| PubCID Script | Adding the PubCID script to work with our ad code or a custom integration. | 365 days | 7 days | Basic | Good | | ||
| PubCID Server | Writing cookie from your web server code directly. | 365 days | 365 days | Intermediate | Best | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedId Server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dev-docs/modules/userId.md
Outdated
@@ -1366,6 +1370,9 @@ pbjs.setConfig({ | |||
userSync: { | |||
userIds: [{ | |||
name: "pubCommonId", | |||
params: { | |||
pixelUrl: "/wp-json/pubcid/v1/extend/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pixelUrl should be specified when the server plugin, so I would make this a no. 3 in the examples list and say something like 3) Publisher supports SharedID and first party domain cookie storage initiated by the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
name: 'sharedId', | ||
name: 'sharedId', //"pubCommonId" as a name is supported for backwards compatibility, | ||
params: { | ||
pixelUrl: "/wp-json/pubcid/v1/extend/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add: '// this parameter identifies your server side endpoint that will set a first party cookie if you have configued SharedId server'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
|
||
### SharedId Script | ||
|
||
For those interested in implementing Sharedid outside of Prebid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without prebid.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
} | ||
``` | ||
|
||
Using a PubCID Server implementation, create the cookie once, which will be allowed to expire before it is created again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedId Server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
identity/sharedid.md
Outdated
2. Drupal : Install from [Github](https://github.com/prebid/sharedid-drupal). | ||
|
||
#### Server Implementations | ||
Below are some examples for how to implement PubCID in various languages or platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedId Server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you, a few comments throughout
updating sharedid examples to include a #3 describing the setConfig when a server is used
adding text around docuement.cookie use in safari
dev-docs/modules/userId.md
Outdated
@@ -1354,8 +1354,12 @@ In addition to the parameters documented above in the Basic Configuration sectio | |||
| name | Required | String | The name of this module. | `'pubCommonId'` | | |||
| params | Optional | Object | Customized parameters | | | |||
| params.create | Optional | Boolean | For publisher server support only. If true, the publisher's server will create the (pubcid) cookie. Default is true. | `true` | | |||
| params.pixelUrl | Optional | String | For publisher server support only. This is a URL of a pixel for updating cookies' expiration times. Fired after a new ID has been created or an existing ID is being extended. No default. | `'https://example.com/ping'` | |||
| params.pixelUrl | Optional | String | For publisher server support only. Where to call out to for a server cookie. | `/wp-json/pubcid/v1/extend/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This server-cookie thing would be mysterious to me if I didn't know about the PubCID first-party server thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a see here for more info link
renaming user id module section and updating desc in table to prebid.js
noting that Pubcid script has a high technical cost and a variable revenue benifit
renaming pubcid server to SharedId Server
adding a comment to pixelURL clarifying what this param should be used for.
updating when sharedid script is appropriate
updating pubcid server to SharedId Server
updating pubcid server to SharedId Server
adding a link to sharedid.html
adding a second link to sharedid.html
adding additional language sharedid servers benefits wrt safari
@jdwieland8282 thanks so much for getting this to the finish line; this doc has some really useful information that will hopefully help publishers more successfully implement. |
adding text to CMS description.
- The term "sharedId server" confused me. I changed most of these to "endpoint" instead of server. - Clarified the term "plugin", which has a meaning in PBJS that's quite different than the usage here. - Removed duplicate exhortations to use the weird "endpoint" thing.
updating the table and text of Sharedid (FKA pubcommon's) entry in the user id section.