Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add userId and GVL ID on adyoulike bidder #3388

Merged
merged 6 commits into from
Feb 9, 2022
Merged

add userId and GVL ID on adyoulike bidder #3388

merged 6 commits into from
Feb 9, 2022

Conversation

guiann
Copy link
Contributor

@guiann guiann commented Nov 4, 2021 •
edited
Loading

linked to this monification in adyoulike bidder adapter:
https://github.com/prdbid/Prebid.js/pull/7660

@guiann guiann mentioned this pull request Nov 4, 2021
Merged
@FlorentDancy
Copy link
Contributor

FlorentDancy commented Nov 4, 2021 •
edited
Loading

Hello,

If I understand correctly your PR here, you are actually collecting all available IDs coming from ID modules (which is great btw!).

In that sense, is it fair to list only 3 IDs in the documentation though?
Or should the documentation just reflect what IDs are actually leveraged by the SSP, and just collected?

Let me know your thoughts!

@guiann
Copy link
Contributor Author

guiann commented Nov 4, 2021

Hello and thank you for your comment.

You totally understand what's done here so your question is very relevant. As the documentation doesn't allow us to mention "all ids are collected", I've just mention partner with which we know we will be working on a short term basis.
The main one being criteo.

Maybe you can help me, on the other PR I was requested informations on test cases for user ids: We're not able to plug a user id module in to get actual data for end to end testing. By any chance, would you have some help to provide on this matter ?

thank you again.

@FlorentDancy
Copy link
Contributor

For the question on the documentation, I've asked the Privacy and Identity PMC community there to get their feedback: https://prebid.slack.com/archives/C016DV7C9J7/p1636035710010800

For the tests, unfortunately I'm not able to help you with this as I've never contributed to Prebid JS code :/

bretg
bretg requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's really no such thing as pubCommonId anymore -- it was renamed to 'shared id'. Please update.

@bretg bretg self-assigned this Nov 10, 2021
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for prebid-docs-preview ready!

🔨 Explore the source changes: bd6ff64

🔍 Inspect the deploy log: https://app.netlify.com/sites/prebid-docs-preview/deploys/6203845a513a9a0008efad20

😎 Browse the preview: https://deploy-preview-3388--prebid-docs-preview.netlify.app

@guiann guiann changed the title add userId support on adyoulike bidder add userId and GVL ID on adyoulike bidder Feb 3, 2022
@guiann
Copy link
Contributor Author

guiann commented Feb 3, 2022

Updated. thx for sharing your comments.

@guiann guiann mentioned this pull request Feb 3, 2022
Merged
8 tasks
@guiann guiann requested a review from bretg February 8, 2022 13:46
bretg
bretg requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guiann - something went wrong with this PR -- there shouldn't be 264 modified files.

@guiann
Copy link
Contributor Author

guiann commented Feb 9, 2022

PR updated

@guiann guiann requested a review from bretg February 9, 2022 09:14
bretg
bretg approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bretg bretg merged commit e63e2fd into prebid:master Feb 9, 2022
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
@guiann @jlaso
add userId and GVL ID on adyoulike bidder (prebid#3388)
992b7b6 
* add getfloor support for adyoulike

* add userId support on adyoulike bidder

* removed obsolete pubCommonId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees

@bretg bretg

Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guiann @FlorentDancy @bretg