Compass Adapter: add new adapter #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2021
CompassSSP
changed the title
guscarreon
reviewed
Dec 7, 2021
dev-docs/bidders/compass.md
Outdated
|
|
||
| ### Note | ||
|
|
||
| For the prebid server, you only need to use one parameter, placementId or endpointId |
There was a problem hiding this comment.
Can we reword to:
34 - For the prebid server, you only need to use one parameter, placementId or endpointId
+ For the prebid server you only need to use one parameter: either placementId or endpointId
|
@guscarreon Our adapter has already been merged and it got into the release https://github.com/prebid/Prebid.js/releases/tag/6.4.0. Please review the doc |
|
@mkendall07 Our adapter has already been merged and it got into the release https://github.com/prebid/Prebid.js/releases/tag/6.4.0. Please review the doc |
|
@guscarreon @MartianTribe @ChrisHuie please react to this pull request. Prebid.js and PrebidServer adapters are already merged and added to the release, but there is no documentation |
|
@guscarreon @MartianTribe @ChrisHuie @fowler446 @bretg please someone answer |
mkendall07
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.