Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pilotx documentation #3451

Merged
merged 5 commits into from
Feb 10, 2022
Merged

Adding pilotx documentation #3451

merged 5 commits into from
Feb 10, 2022

Conversation

AnthonyBoozan
Copy link
Contributor

No description provided.

@ChrisHuie ChrisHuie mentioned this pull request Dec 13, 2021
Merged
2 tasks
bretg
bretg requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put quotes around your string parameter

@MartianTribe
Copy link
Collaborator

What's the status with this? Does it still need work? The code was merged in 6.7.0

@netlify
Copy link

netlify bot commented Feb 8, 2022 •
edited
Loading

✔️ Deploy Preview for prebid-docs-preview ready!

🔨 Explore the source changes: 4ed06ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/prebid-docs-preview/deploys/6204342fcfb3ec0008e9dd40

😎 Browse the preview: https://deploy-preview-3451--prebid-docs-preview.netlify.app

@AnthonyBoozan
Copy link
Contributor Author

If you need anything else from me just let me know, I also noticed the merge and neglected to confirm the documentation needed work.

@bretg
Copy link
Contributor

bretg commented Feb 9, 2022 •
edited
Loading

@AnthonyBoozan - your parameter is declared as a string but doesn't have quotes around it. Please fix.

(For the record, backticks are highlights and will not appear as quotes in the final render)

@AnthonyBoozan
Copy link
Contributor Author

Ok I've added the quotations to the string in the documentation. My apologies and if you need anything else let me know!

@bretg bretg merged commit 8ba10e3 into prebid:master Feb 10, 2022
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
@AnthonyBoozan @PilotxMachineUser @jlaso
Adding pilotx documentation (prebid#3451)
e2a0bb4 
* Adding pilotx documentation

* adding quotes for string in documention

Co-authored-by: AnthonyBoozan <tony@pilotx.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartianTribe MartianTribe MartianTribe approved these changes

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyBoozan @MartianTribe @bretg @PilotxMachineUser