Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$$PREBID_GLOBAL$$.bidderTimeout
- Moved to configprebid/Prebid.js#1633 PR is not merged but it removes
$$PREBID_GLOBAL$$._adsReceived
(You already added that)$$PREBID_GLOBAL$$.timeoutBuffer
- Moved to config$$PREBID_GLOBAL$$.logging
- Moved to config$$PREBID_GLOBAL$$.publisherDomain
- Moved to config$$PREBID_GLOBAL$$.setBidderSequence
- Moved to config$$PREBID_GLOBAL$$.setS2SConfig
- Moved to configThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaiminpanchal27 what is
$$PREBID_GLOBAL$$.bidderTimeout
used for? Shouldn't this just be set in requestBids?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
pbjs.timeoutBuffer
but the rest are covered in thepbjs.setConfig
section below this.