Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMNS: Update documentation for the new Teads User Id Module #4026

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

github-tom-kuhnen
Copy link
Contributor

@github-tom-kuhnen github-tom-kuhnen commented Sep 19, 2022

/!\ Do not review for now as the module is not released yet

🏷 Type of documentation

  • new feature

📋 Checklist

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit b6d4207
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63495475dd92620008b8b547
😎 Deploy Preview https://deploy-preview-4026--prebid-docs-preview.netlify.app/dev-docs/modules/userid
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MartianTribe
Copy link
Collaborator

Is there a code PR associated with this docs PR?

@github-tom-kuhnen
Copy link
Contributor Author

Is there a code PR associated with this docs PR?

Yes, I updated the description with the PR link, but as I noticed in the description, for now this PR is in draft and doesn't have to be reviewed until the module is released :)

@github-kylian-deau
Copy link
Contributor

Hello @bretg thanks for the approval, would it be possible to merge this PR ? Indeed, new Teads User Id module has been released yesterday in prebid 7.20.0 version (see https://github.com/prebid/Prebid.js/releases/tag/7.20.0).

Thanks in advance !

@bretg
Copy link
Contributor

bretg commented Oct 14, 2022

@github-kylian-deau - why is this PR marked as draft?

@github-kylian-deau
Copy link
Contributor

github-kylian-deau commented Oct 14, 2022

@bretg There is no reason for it to be marked as draft. It seems i don't have the rights to mark it as "ready to review", as there is a message saying "Only those with write access to this repository can mark a draft pull request as ready for review."

@bretg bretg marked this pull request as ready for review October 16, 2022 00:35
@bretg bretg merged commit 6d62433 into prebid:master Oct 16, 2022
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants