Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fledgeForGpt Module Docs #4089

Merged
merged 3 commits into from
Nov 23, 2022
Merged

fledgeForGpt Module Docs #4089

merged 3 commits into from
Nov 23, 2022

Conversation

JoelPM
Copy link
Contributor

@JoelPM JoelPM commented Oct 19, 2022

Add documentation for the experimental FLEDGE support module. This is linked with:
prebid/Prebid.js#9127

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked

Add documentation for the experimental FLEDGE support module.
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 8635065
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/637e58e8f39b430009a28f53
😎 Deploy Preview https://deploy-preview-4089--prebid-docs-preview.netlify.app/dev-docs/modules/fledgeforgpt
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@fowler446 fowler446 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelPM
This module is missing front matter.

IE it needs something like:

---
layout: page_v2
page_type: module
title: Module - fledgeForGpt
description: 
module_code :
display_name : 
enable_download : true
sidebarType : 1
---

adding layout header
@jdwieland8282
Copy link
Member

Thanks for catching that @fowler446 I've add layout headers

@JoelPM
Copy link
Contributor Author

JoelPM commented Oct 26, 2022

Thanks for the help @jdwieland8282 !

@bretg bretg added LGTM and removed needs work labels Nov 23, 2022
@bretg bretg merged commit cd9d3c9 into prebid:master Nov 23, 2022
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* fledgeForGpt Module Docs

Add documentation for the experimental FLEDGE support module.

* Update fledgeForGpt.md

adding layout header

* relative links, related reading

Co-authored-by: jdwieland8282 <wieland.jeff@gmail.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants