Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBJS: document new genericAnalyticsAdapter module #4092

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

dgirardi
Copy link
Contributor

🏷 Type of documentation

  • new feature: generic analytics adapter module

📋 Checklist

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 18310de
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63bd8a04fd00470008b1afa9
😎 Deploy Preview https://deploy-preview-4092--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -0,0 +1,13 @@
---
layout: analytics
title: Generic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried generic might be confusing and lead to a vendorless module being used by a vendor. The name change won't prevent this from happening, but perhaps we want to be more clear this is meant to send events to the pub controlled cdn.

Copy link
Contributor Author

@dgirardi dgirardi Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually planned to accept a gvlid configuration parameter, to allow this to be truly generic, but cut it once I realized that a) GDPR enforcement is turned off by default for purpose 7; and b) the current enforcement mechanism would need more refactoring than I hoped.

Would that be preferable than trying to restrict this to pub-controlled endpoints only? I'm thinking that especially for those analytics backends that just expect to get data dumped into a globally defined function, it's a bit silly to require an adapter that just provides that function's name. Examples:

if we add a way to specify the gvlid, those could easily be fronted by this module.

@ChrisHuie ChrisHuie merged commit 968a8bf into prebid:master Jan 10, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* PBJS: document new `genericAnalyticsAdapter` module

* Try using "N/A" as gvlid for generic analytics

* Move generic analytics docs to its own page

* softVendorExceptions, generic analytics note on gdpr enforcement

* add min version

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants