-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Module: Initial Release #4100
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
<a name="adUnit-video-example-instream"> | ||
|
||
#### Instream | ||
|
||
For an example of an instream video ad unit, see below. For more detailed instructions, see [Show Video Ads]({{site.baseurl}}/dev-docs/show-video-with-a-dfp-video-tag.html). | ||
For an example of an instream video ad unit that you handle on your own, see below. For more detailed instructions, see [Show Video Ads]({{site.baseurl}}/dev-docs/show-video-with-a-dfp-video-tag.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the intention here with the addition of "that you handle on your own"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the intention is to distinguish between using the video module to integrate vs "doing it yourself"
@karimMourra I added a sidebar navigation to the new modules. However the commits don't appear on the PR even they live on the same branch: https://github.com/prebid/prebid.github.io/commits/feat/AD-1416 not sure what I messed up :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the extensive and comprehensive documenation @karimMourra ❤️
From my limited understanding I would give this a go. @fowler446 maybe you want to give it another look as well
Co-authored-by: Andrew <fowler446@users.noreply.github.com>
14ac4f1
to
76ccd60
Compare
* adds video module section * populates independent integration section * populates SSP section * populates config and ad unit * populates features * populates bid enrichment * creates how to add subm * completes how to add * links to ad unit ref * adds module docs * populates payload descr * populates all params * cleans typos * adds requirements * Update dev-docs/add-video-submodule.md Co-authored-by: Andrew <fowler446@users.noreply.github.com> * adds missing punctuation * Add prebid video module to sidebar * Fix video-integrating-solo link * removes extra AdPlayer.Pro section * clarifies vendor code constants * putting spaces into the long args Co-authored-by: Andrew <fowler446@users.noreply.github.com> Co-authored-by: Nepomuk Seiler <nepomuk.seiler@gutefrage.net> Co-authored-by: bretg <bgorsline@gmail.com>
Documentation for the new Prebid Video Module prebid/Prebid.js#8858
🏷 Type of documentation
📋 Checklist