Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Module: Initial Release #4100

Merged
merged 21 commits into from
Oct 28, 2022
Merged

Video Module: Initial Release #4100

merged 21 commits into from
Oct 28, 2022

Conversation

karimMourra
Copy link
Contributor

Documentation for the new Prebid Video Module prebid/Prebid.js#8858

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • new core module
  • new video provider modules
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit ebe9b28
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/635c0302cecf9e000ac5bd68
😎 Deploy Preview https://deploy-preview-4100--prebid-docs-preview.netlify.app/dev-docs/publisher-api-reference/setconfig
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karimMourra
Copy link
Contributor Author

cc @FranciscoVergaraC

<a name="adUnit-video-example-instream">

#### Instream

For an example of an instream video ad unit, see below. For more detailed instructions, see [Show Video Ads]({{site.baseurl}}/dev-docs/show-video-with-a-dfp-video-tag.html).
For an example of an instream video ad unit that you handle on your own, see below. For more detailed instructions, see [Show Video Ads]({{site.baseurl}}/dev-docs/show-video-with-a-dfp-video-tag.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intention here with the addition of "that you handle on your own"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention is to distinguish between using the video module to integrate vs "doing it yourself"

@muuki88
Copy link
Contributor

muuki88 commented Oct 27, 2022

@karimMourra I added a sidebar navigation to the new modules. However the commits don't appear on the PR even they live on the same branch: https://github.com/prebid/prebid.github.io/commits/feat/AD-1416

not sure what I messed up :D

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the extensive and comprehensive documenation @karimMourra ❤️

From my limited understanding I would give this a go. @fowler446 maybe you want to give it another look as well

dev-docs/adunit-reference.md Outdated Show resolved Hide resolved
dev-docs/publisher-api-reference/setConfig.md Show resolved Hide resolved
@muuki88 muuki88 merged commit 768c2e5 into prebid:master Oct 28, 2022
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* adds video module section

* populates independent integration section

* populates SSP section

* populates config and ad unit

* populates features

* populates bid enrichment

* creates how to add subm

* completes how to add

* links to ad unit ref

* adds module docs

* populates payload descr

* populates all params

* cleans typos

* adds requirements

* Update dev-docs/add-video-submodule.md

Co-authored-by: Andrew <fowler446@users.noreply.github.com>

* adds missing punctuation

* Add prebid video module to sidebar

* Fix video-integrating-solo link

* removes extra AdPlayer.Pro section

* clarifies vendor code constants

* putting spaces into the long args

Co-authored-by: Andrew <fowler446@users.noreply.github.com>
Co-authored-by: Nepomuk Seiler <nepomuk.seiler@gutefrage.net>
Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants