-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add retailspot documentation #4490
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rs-guian - if you're going to claim GDPR support, you almost certainly require a GVL ID. Also, please supply the other metadata fields:
coppa_supported:
userIds:
safeframes_ok:
deals_supported:
fpd_supported:
ortb_blocking_supported:
gvl_id:
multiformat_supported:
I'll add those. We haven't got a GVL id though. We claim to support GDPR as sellers: Transmitting user consent information to buyers. We don't need to request user consent ourselves as we won't read/store nor use user cookie informations. I will update our GVL ID accordingly if this should change. In the meantime would you mind having a look at our test page where no ad is never shown whereas bid response is always filled up ? |
![]() Test page is looking good 👍 @rs-guian |
Everything looks good. thank you |
dev-docs/bidders/retailspot.md
Outdated
pbs: false | ||
media_types: banner, video | ||
biddercode: retailspot | ||
gdpr_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Bret mentioned, if you claim gdpr_support
your must provide a gvl_id
here.
gvl_id: <your id here>
@rs-guian either add a |
Thanks for your patience @rs-guian We'll discuss the GVL_ID topic today in the docs committee. |
We discussed this topic @rs-guian . You have to set the gdpr_supported flag to false.
But in the end, from a Prebid perspective, you do not support GDPR if you don't have a GVLID. |
Got it, thanks a lot for discussing it and giving me this well-argued answer. |
Done. We'll claim our GDPR ID and update the value soon. Thank you again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Released with PBJS 7.49. Merging. |
* add retailspot documentation * add support information * change gdpr support to false for now --------- Co-authored-by: guiann <guillaume.andouard@adyoulike.com>
🏷 Type of documentation
Related pull requests in prebid.js: