Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTB House Bid Adapter: docs update - bcat & badv ORTB params support #4522

Merged
merged 16 commits into from
May 12, 2023

Conversation

piotrj-rtbh
Copy link
Contributor

@piotrj-rtbh piotrj-rtbh commented Apr 26, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit ac4e2fd
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/645de6d5e22e62000888187f
😎 Deploy Preview https://deploy-preview-4522--prebid-docs-preview.netlify.app/dev-docs/pbs-bidders
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@piotrj-rtbh piotrj-rtbh changed the title RTB House Bid Adapter: update docs - ORTB blocking support RTB House Bid Adapter: docs update - ORTB blocking support Apr 26, 2023
@piotrj-rtbh piotrj-rtbh marked this pull request as ready for review April 26, 2023 12:30
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piotrj-rtbh for updating the docs.

I couldn't find any related pull request to your adapter and the code seems to not add the badv and bcat fields:

https://github.com/prebid/Prebid.js/blob/22ff9c276e35e92087e5708d292b21a2ae1d3c1a/modules/rtbhouseBidAdapter.js#L53-L96

@piotrj-rtbh
Copy link
Contributor Author

piotrj-rtbh commented Apr 28, 2023

A new PR has been pushed (see above). It still fails (circle-ci) due to somebody else's test failing.

@piotrj-rtbh
Copy link
Contributor Author

Hey @muuki88, the Prebid.js PR has been accepted and merged. Feel free to merge this doc PR as well. Thank you in advance!

@piotrj-rtbh piotrj-rtbh changed the title RTB House Bid Adapter: docs update - ORTB blocking support RTB House Bid Adapter: docs update - bcat & badv ORTB params support May 2, 2023
@ChrisHuie ChrisHuie merged commit 9d70746 into prebid:master May 12, 2023
myDisconnect pushed a commit to eskimi/prebid.github.io that referenced this pull request May 23, 2023
…ort (prebid#4522)

* RTBHouse Bid Adapter: adds channel as optional param, updates bidder flags

* RTBHouse Bid Adapter: fixed table descriptions

* RTBHouse Bid Adapter: minor textual changes on bidder docs

* ortb_blocking_supported and description section

* ortb_blocking_supported and description section (prebid#1)

* ortb_blocking_supported and description section

* rephrasing

* ORTB blocking examples update

* Javascript type for examples added

* typo fix

* code fix

* Prebid Server setup by host companies

---------

Co-authored-by: Leandro Otani <leandro.otani@rtbhouse.com>
Co-authored-by: rtbh-lotani <83652735+rtbh-lotani@users.noreply.github.com>
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
…ort (prebid#4522)

* RTBHouse Bid Adapter: adds channel as optional param, updates bidder flags

* RTBHouse Bid Adapter: fixed table descriptions

* RTBHouse Bid Adapter: minor textual changes on bidder docs

* ortb_blocking_supported and description section

* ortb_blocking_supported and description section (#1)

* ortb_blocking_supported and description section

* rephrasing

* ORTB blocking examples update

* Javascript type for examples added

* typo fix

* code fix

* Prebid Server setup by host companies

---------

Co-authored-by: Leandro Otani <leandro.otani@rtbhouse.com>
Co-authored-by: rtbh-lotani <83652735+rtbh-lotani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants