vox adapter add support schain, userid, floors module #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
muuki88
approved these changes
Jul 8, 2023
muuki88
reviewed
Jul 8, 2023
| @@ -2,6 +2,9 @@ | |||
| layout: bidder | |||
| title: VOX | |||
| description: Prebid VOX Bidder Adapter | |||
| schain_supported: true | |||
| floors_supported: true | |||
| userIds: all | |||
| pbjs: true | |||
| media_types: banner, video | |||
There was a problem hiding this comment.
While you are at it: We recommend adding the following fields as well
- safeframes_ok: true/false
- multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
There was a problem hiding this comment.
- hard to say if we ok on safeframes) Some ad unit types like usual display banner ok with safeframes, while inImage is not supports safeframe
- About the second param - multiformat_supported. Can you please show me where description of this param can be found?
There was a problem hiding this comment.
About safeframes for now i will set to false, but before need to know meaning of the second param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist