Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pangle md #4823

Merged
merged 4 commits into from
Sep 8, 2023
Merged

feat: update pangle md #4823

merged 4 commits into from
Sep 8, 2023

Conversation

bytedancer-1
Copy link
Contributor

@bytedancer-1 bytedancer-1 commented Aug 28, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 906dccd
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/64f9420f1e229b00088bc81b
😎 Deploy Preview https://deploy-preview-4823--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg
Copy link
Contributor

bretg commented Aug 30, 2023

@bytedancer-1 - thanks for the submission -- a couple of comments:

  • please fix linting errors
  • Prebid publishers are unhappy when bidders have different parameters between client-side and server-side adapters. It prevents them from using the server-to-server test module for your bidder. I've added you to the list of similarly out-of-line adapters at Adapter naming and parameter consistency prebid-server#2654

@bytedancer-1
Copy link
Contributor Author

Update the same parameters, please help to see, no problem to help merge into it

@bytedancer-1
Copy link
Contributor Author

client-bid has been incorporated, please help to see, no problem to help merge into it。

dev-docs/bidders/pangle.md Outdated Show resolved Hide resolved
dev-docs/bidders/pangle.md Outdated Show resolved Hide resolved
@bytedancer-1
Copy link
Contributor Author

@bretg I am very sorry for my carelessness. Please review it again and help me put it in if there is no problem

@bytedancer-1
Copy link
Contributor Author

I see that it has been approved, but it has not been merged. Please help me merge it

@bretg
Copy link
Contributor

bretg commented Sep 8, 2023

@bytedancer-1 - FYI - we don't merge docs until the relatedcode is released, and then sometimes there can be a delay because it's different people.

Anyhow, confirmed that the code is now released, so merging.

@bretg bretg merged commit f362964 into prebid:master Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants