AdView: support multi imps request, related to prebid-server adapter PR #3355 #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
muuki88
approved these changes
Feb 3, 2024
|
Add support for safe frames. |
ChrisHuie
reviewed
Feb 15, 2024
| bidder_supports_deals: true | ||
| pbjs: false | ||
| pbs: true | ||
| pbs_app_supported: true | ||
| prebid_member: false | ||
| sidebarType: 1 |
There was a problem hiding this comment.
can you add back sidebarType
There was a problem hiding this comment.
sidebarType add, many thanks.
|
add sidebarType. |
muuki88
requested changes
Mar 7, 2024
dev-docs/bidders/adview.md
Outdated
| @@ -7,23 +7,24 @@ tcfeu_supported: true | |||
| gvl_id: 1022 | |||
| usp_supported: true | |||
| coppa_supported: true | |||
| gpp_supported: true | |||
There was a problem hiding this comment.
gpp_supported is deprecated. You have to be more specific on what you actually support
Suggested change
| gpp_supported: true | |
| gpp_sids: // the sections you support. List of cfeu, tcfca, usnat, usstate_all, usp |
There was a problem hiding this comment.
ok, changed gpp_support to gpp_sids, pls check it again.
muuki88
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist
AdView: support multi imps request & formattype tag for bid response prebid-server#3355