Adkernel: documenting global_sun alias #5471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Why are there two globalsun adapter docs in the PR? @ckbo3hrk |
|
There are now two adapters with the same name :( Should we revert the alias pr? |
@patmmccann I've contacted the partner network and they made a pull request to remove obsolete adapter prebid/Prebid.js#11972 |
|
That's a breaking change though if anyone has it in their build script their build will break |
|
Can you change the alias name to global_sun? We have precedent with this for emxdigital |
|
we reverted the alias, feel free to pick a new name prebid/Prebid.js#11983 |
ckbo3hrk
changed the title
patmmccann
approved these changes
Jul 18, 2024
|
Is there anything else we need to do to merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist