-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile refactoring: adops focus #5507
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the review is still in progress. I'm just committing comments once they arise
prebid-mobile/recipes/subrecipes/ios/gam-bidding-only-html-banner.md
Outdated
Show resolved
Hide resolved
prebid-mobile/recipes/subrecipes/android/gam-bidding-only-html-banner.md
Show resolved
Hide resolved
_includes/mobile/intro-custom.md
Outdated
We recommend that you study the flows documented in these different rendering approaches: | ||
|
||
- [Bidding-Only](/prebid-mobile/pbm-api/{{include.platform}}/{{include.platform}}-sdk-integration-gam-original-api.html#how-it-works) - generally this approach utilizes webviews and the Prebid Universal Creative to render most types of ads. | ||
- [Prebid-Rendered](/prebid-mobile/modules/rendering/{{include.platform}}-sdk-integration-gam.html) - with this approach the Prebid SDK will render any bids that are chosen for display. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is irrelevant to the integration with Custom Server. Publishers can't just replace the GMA sd with a custom one. The flow in the "Prebid-Rendered" approach is relevant only to the GAM platform and its features. So, this item and lines 28-31 can mislead integrators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular page utilizes the same tiles in a different manner:
- Bidding only
- in the beginning of the doc it refers to the GAM SDK + PUC integration scenario
- then it refers to a scenario with a custom server that does not necessarily use PUC. The custom server can process the raw bid and render it's
adm
.
- Prebid Rendered
- in the beginning of the doc it refers to the GAM SDK + Prebid Event Handlers + Prebid SDK integration scenario
- then it refers to the Prebid SDK Rendering API.
It can confuse a reader a bit, too.
I think that we should skip the detailed description of GAM-based scenarios in this integration approach - ios-sdk-integration-pb page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuriyVelichkoPI - sorry, not following. Honestly I got lazy here, honestly don't understand the scenario, and didn't want to wind up with a lot of duplicate text. And I question whether anyone is actually going to do this.
So my goal is to provide an outline of some things to think about. If you're saying that the "Prebid Rendered" scenario is not supported, fine, I can remove all references to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal was to provide info about other scenarios on this page - we can keep everything as is.
Applovin to AppLovin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Giving the community a chance to do a focused review on the line item and creative consideration pages. Goal is to merge on Monday |
Thanks a lot 🙏 This is huge |
Some sections that are ready for review: