-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EClickAds: rename bidder from EClickAds to eClick #5556
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@CMDezz if you change an existing adapter like this, the documentation for the old prebid 9 and lower documentation will be gone. Is this okay for your customers? |
@muuki88 Yes, that's okay. We've considered this and decided to change the adapter's name. |
Hi @CMDezz We discussed this and sorry that there's a gap our documentation. If you want to rename your adapter, the old file must remain and a new one for the new name is created. The old file should contain pbjs version notes in which versions this adapter is available. https://docs.prebid.org/faq/prebid-server-faq.html#how-can-we-rename-our-bid-adapter |
🏷 Type of documentation
📋 Checklist
-> EClickAds: rename bidder from EClickAds to eClick Prebid.js#12145
This commit does nothing but change the bidder name from
EClickAds
toeClick
(alsobidderCode
fromeclickads
toeclick
)