Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EClickAds: rename bidder from EClickAds to eClick #5556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CMDezz
Copy link
Contributor

@CMDezz CMDezz commented Aug 20, 2024

🏷 Type of documentation

  • text edit only (wording, typos)

📋 Checklist

This commit does nothing but change the bidder name from EClickAds to eClick (also bidderCode from eclickads to eclick)

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit d1969c7
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66cc355411612200086f195b
😎 Deploy Preview https://deploy-preview-5556--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CMDezz CMDezz marked this pull request as draft August 20, 2024 03:23
@CMDezz CMDezz marked this pull request as ready for review August 20, 2024 04:29
@muuki88
Copy link
Contributor

muuki88 commented Aug 22, 2024

@CMDezz if you change an existing adapter like this, the documentation for the old prebid 9 and lower documentation will be gone. Is this okay for your customers?

@CMDezz
Copy link
Contributor Author

CMDezz commented Aug 23, 2024

@muuki88 Yes, that's okay. We've considered this and decided to change the adapter's name.

@muuki88
Copy link
Contributor

muuki88 commented Aug 25, 2024

Hi @CMDezz

We discussed this and sorry that there's a gap our documentation.

If you want to rename your adapter, the old file must remain and a new one for the new name is created. The old file should contain pbjs version notes in which versions this adapter is available.

https://docs.prebid.org/faq/prebid-server-faq.html#how-can-we-rename-our-bid-adapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants