Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dichange Adapter #5591

Closed
wants to merge 4 commits into from
Closed

add Dichange Adapter #5591

wants to merge 4 commits into from

Conversation

Chucky-choo
Copy link

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 743e0e4
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66e407def303590008c21adb
😎 Deploy Preview https://deploy-preview-5591--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally publisher documentation will provide some registration contact information for the publisher.

usp_supported: true
prebid_member: false
pbjs: true
pbs: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a Prebid Server pull request in either Go or Java. But you also have a table of PBS params below. Please post a link to the relevant PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mistake, this adapter really doesn't have pbs support yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chucky-choo , but the body of the document also lists Prebid Server parameters. That should be removed too, yes?

@Chucky-choo Chucky-choo requested a review from bretg September 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants