-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dichange Adapter #5591
add Dichange Adapter #5591
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally publisher documentation will provide some registration contact information for the publisher.
dev-docs/bidders/dichange.md
Outdated
usp_supported: true | ||
prebid_member: false | ||
pbjs: true | ||
pbs: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a Prebid Server pull request in either Go or Java. But you also have a table of PBS params below. Please post a link to the relevant PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the mistake, this adapter really doesn't have pbs support yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Chucky-choo , but the body of the document also lists Prebid Server parameters. That should be removed too, yes?
🏷 Type of documentation
📋 Checklist