Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exco bidder documentation #5652

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Add Exco bidder documentation #5652

merged 7 commits into from
Nov 12, 2024

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Oct 10, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 85cd93c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67336bb5751f720008b5a89e
😎 Deploy Preview https://deploy-preview-5652--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the build failure is related to this PR. Please make the requested updates and the next run should succeed.

dev-docs/bidders/exco.md Show resolved Hide resolved
dev-docs/bidders/exco.md Show resolved Hide resolved
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saar120 can you make the requested changes? You prebid adapter has been merged and now the documentation is eligible to merged as well.

dev-docs/bidders/exco.md Show resolved Hide resolved
@bretg
Copy link
Contributor

bretg commented Nov 12, 2024

Please fix the linting error

dev-docs/bidders/exco.md:37 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```javascript"] 

@bretg bretg added LGTM and removed needs work labels Nov 12, 2024
@bretg
Copy link
Contributor

bretg commented Nov 12, 2024

Thanks for the docs fixes. This was part of PBJS 9.17. Merging the docs.

@bretg bretg merged commit 4e73571 into prebid:master Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants