Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation for districtmDMX for version 1+ #876

Merged
merged 8 commits into from
Aug 10, 2018

Conversation

stevealliance
Copy link
Contributor

No description provided.

@bretg
Copy link
Contributor

bretg commented Jul 11, 2018

@stevealliance - these changes look fine, but have to ask about whether removing the original docs is what you intended. Many pubs are still on PBJS 0.x, so perhaps you still want to have your adapter docs describe the 0.x params for an interim period?

@bretg bretg added the question label Jul 11, 2018
@stevealliance
Copy link
Contributor Author

@bretg good question we can still keep the old config for our previous adapter you want update my pr?

@bretg
Copy link
Contributor

bretg commented Jul 11, 2018

Yes - you can update this PR. Either make another table for 0.x params, or add a column to the existing table to note which parameter goes with which version.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we agreed that this doc should cover both 0.x and 1.x

Steve Alliance and others added 3 commits July 31, 2018 18:10
Added examples to 0.34 and 1.0+, type to 1.0+
Update districtmdmx.md
@stevealliance
Copy link
Contributor Author

updating documentation for DMX for prebid version 1+

@stevealliance
Copy link
Contributor Author

@bretg how do we get added to the download page... We do have a new adapter in Prebid.js project, but I don't see our script listed and we are in Prebid since version 1.5.

Thanks

lsv1 and others added 2 commits August 1, 2018 22:37
I made a mistake! Can you make sure it's a string for the floor param?
Update districtmdmx.md
@stevealliance
Copy link
Contributor Author

Hi @matthewlane how can we get added to the download page

this is how to to get your adapter to show up in the 1.0 downloads list
@bretg bretg merged commit fc516bc into prebid:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants