-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating documentation for districtmDMX for version 1+ #876
Conversation
@stevealliance - these changes look fine, but have to ask about whether removing the original docs is what you intended. Many pubs are still on PBJS 0.x, so perhaps you still want to have your adapter docs describe the 0.x params for an interim period? |
@bretg good question we can still keep the old config for our previous adapter you want update my pr? |
Yes - you can update this PR. Either make another table for 0.x params, or add a column to the existing table to note which parameter goes with which version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we agreed that this doc should cover both 0.x and 1.x
Added examples to 0.34 and 1.0+, type to 1.0+
Update districtmdmx.md
updating documentation for DMX for prebid version 1+ |
@bretg how do we get added to the download page... We do have a new adapter in Prebid.js project, but I don't see our script listed and we are in Prebid since version 1.5. Thanks |
I made a mistake! Can you make sure it's a string for the floor param?
Update districtmdmx.md
Hi @matthewlane how can we get added to the download page |
this is how to to get your adapter to show up in the 1.0 downloads list
No description provided.