Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed cookieSyncDelay from config #981

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

thewizarodofoz
Copy link
Contributor

Removed cookieSyncDelay from config since we have more configuration options now with the userSync object.

Documents prebid/Prebid.js#3061.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this should be handled in a different way -- we should add a deprecation notice right now, and not actually remove it until 2.0.

@bretg
Copy link
Contributor

bretg commented Oct 1, 2018

thanks for this @thewizarodofoz -- but since we can't merge it until 2.0 -- API change, I think we want to add the deprecation now and remove it later.

@thewizarodofoz
Copy link
Contributor Author

Yes I thought a deprecation notice is more suitable, but then I saw that cookieSyncDelay is actually not being used anywhere in the master branch (except for in the config object itself).

The user sync module is using the new syncDelay param. So unless I am missing something, I think leaving cookieSyncDelay is actually misleading.

@thewizarodofoz
Copy link
Contributor Author

@bretg
Copy link
Contributor

bretg commented Oct 10, 2018

Ok.

@bretg bretg merged commit c736119 into prebid:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants