-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for non-consented vendor calls #65
Comments
related: prebid/Prebid.js#9088 |
We will need to generate a chain of network calls initiated by prebid modules (bidders, user-id modules). |
Jason is working on generating a chain of network calls initiated in user-sync process to display in the Professor Prebid |
Hi @patmmccann @ChrisHuie @pm-harshad-mane (feel free to tag anyone else that you think should be included on this thread as well) Just created a PR (linked above to this issue ticket) for the first iteration of a tool within Prof Prebid that can generate a chain of network calls that initiate based on a provided user sync URL. Under the hood this tool relies on Chrome's devtools network API. I've created a quick video demonstrating what I've built out so far to make things easier to visualize (the video also explains how to use the tool): https://vimeo.com/835964741 Since this is a POC, I'm definitely expecting feedback, so was curious to see what your thoughts on this are and what the "next steps" might look like. Some known "todo-items" for improvement based on some feedback I have already come across include the following:
|
Hi @jlquaccia , thanks a lot for your PR! I applied your changes to https://github.com/prebid/professor-prebid/tree/version-0.2.64. I have created a dev-tool-panel in version 0.2.63 and added it directly there: |
Hey @florianerl, No problem! Also, nice! I will take a look soon this week and get back to you. |
Hey @florianerl, Getting around to some more Prof Prebid work this week. Nice, looks good where you put the module I made! Just took a look on the branch that you mentioned above. I'm planning on addressing some changes this week to the Network Inspector module I was working on.. which includes the following:
Will update you once I have a new PR ready to be reviewed. |
Hi @jlquaccia , what do you think of using typescript for src/pages/Devtools/index.js ? Just for the sakes of uniformity? |
Hey Florian,
Ah, good call out. Yes, I can definitely use TypeScript in that file 👍
…On Wed, Jun 28, 2023 at 1:19 AM Florian Erl ***@***.***> wrote:
Hi @jlquaccia <https://github.com/jlquaccia> ,
what do you think of using typescript for src/pages/Devtools/index.js ?
Just for the sakes of uniformity?
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABX6NQY33DX7DKTNUVXLVKLXNPSKZANCNFSM6AAAAAAYNXEPN4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey @florianerl, Just submitted a new PR addressing a few things, including converting src/pages/Devtools/index.js to now use TypeScript. Take a look when you have some time. The description on the PR contains more info about the changes I made. PR: #71 |
We'd love to flag non-consented vendors appearing in user syncs and markups. The google additional consent list has a map of domain to gvl id and acl id at https://storage.googleapis.com/tcfac/additional-consent-providers.csv
The text was updated successfully, but these errors were encountered: