Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for non-consented vendor calls #65

Open
patmmccann opened this issue May 24, 2023 · 10 comments
Open

Check for non-consented vendor calls #65

patmmccann opened this issue May 24, 2023 · 10 comments

Comments

@patmmccann
Copy link

patmmccann commented May 24, 2023

We'd love to flag non-consented vendors appearing in user syncs and markups. The google additional consent list has a map of domain to gvl id and acl id at https://storage.googleapis.com/tcfac/additional-consent-providers.csv

@patmmccann
Copy link
Author

related: prebid/Prebid.js#9088

@pm-harshad-mane
Copy link

We will need to generate a chain of network calls initiated by prebid modules (bidders, user-id modules).
The Chrome Network panel helps but we will need to putt extra checks and highlight when a signal is not passed by a partner. The Proff Prebid should not always run this analysis, this flow should be initiated at user request.

@pm-harshad-mane
Copy link

Jason is working on generating a chain of network calls initiated in user-sync process to display in the Professor Prebid

@jlquaccia
Copy link
Contributor

jlquaccia commented Jun 14, 2023

Hi @patmmccann @ChrisHuie @pm-harshad-mane (feel free to tag anyone else that you think should be included on this thread as well)

Just created a PR (linked above to this issue ticket) for the first iteration of a tool within Prof Prebid that can generate a chain of network calls that initiate based on a provided user sync URL. Under the hood this tool relies on Chrome's devtools network API. I've created a quick video demonstrating what I've built out so far to make things easier to visualize (the video also explains how to use the tool): https://vimeo.com/835964741

Since this is a POC, I'm definitely expecting feedback, so was curious to see what your thoughts on this are and what the "next steps" might look like. Some known "todo-items" for improvement based on some feedback I have already come across include the following:

  • Remove the “refresh” button (but of course keep the functionality to generate the init req chain object in UI.. would seem cleaner and more intuitive without the button).
  • Some kind of loading animation would be nice to display while a request chain is generating.
  • As of right now, the root url to listen for to generate an init req object from can be any url (there is a form field that accepts any value). In the future I was thinking that maybe we could hardcode just user sync url's within a dropdown select field perhaps? to make this more restricted?

@florianerl
Copy link
Collaborator

Hi @jlquaccia ,

thanks a lot for your PR! I applied your changes to https://github.com/prebid/professor-prebid/tree/version-0.2.64. I have created a dev-tool-panel in version 0.2.63 and added it directly there:
image
Let me know what you think please

@jlquaccia
Copy link
Contributor

Hey @florianerl,

No problem! Also, nice! I will take a look soon this week and get back to you.

@jlquaccia
Copy link
Contributor

Hey @florianerl,

Getting around to some more Prof Prebid work this week. Nice, looks good where you put the module I made! Just took a look on the branch that you mentioned above. I'm planning on addressing some changes this week to the Network Inspector module I was working on.. which includes the following:

  • removing the "refresh" button (but keeping the functionality and automating it, so the dependency of a button click is not needed)
  • some style changes
  • add a loading animation while the init request chain is being updated/built

Will update you once I have a new PR ready to be reviewed.

@florianerl
Copy link
Collaborator

Hi @jlquaccia ,

what do you think of using typescript for src/pages/Devtools/index.js ? Just for the sakes of uniformity?

@jlquaccia
Copy link
Contributor

jlquaccia commented Jun 28, 2023 via email

@jlquaccia
Copy link
Contributor

Hey @florianerl,

Just submitted a new PR addressing a few things, including converting src/pages/Devtools/index.js to now use TypeScript. Take a look when you have some time. The description on the PR contains more info about the changes I made.

PR: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants